Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend fixes for #1113 #1200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mchateauvert
Copy link

Frontend fixes for issue #1113:

  • Revert previous merge on this issue which prevented negative stock levels
  • Add a warning/confirmation dialog before allowing the user to create negative stock levels

Per discussions on the bug tracker negative stock levels are an intended feature covering a common use case, so this should close the issue.

Happy to hear suggestions for improvements to the warning text.

Tested via Chrome devtools but I could not get the docker dev image working to build and test.

UserWarningMessage

Revert max value limitation. Negative stock values are allowed/expected behavior in some circumstances.
Add confirmation dialog before allowing user to create negative stock levels. Should close issue partkeepr#1113.
@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #1200 (0cd8b38) into master (c6323d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1200   +/-   ##
=========================================
  Coverage     36.87%   36.87%           
  Complexity     1803     1803           
=========================================
  Files           258      258           
  Lines          5763     5763           
=========================================
  Hits           2125     2125           
  Misses         3638     3638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6323d5...0cd8b38. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants